Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proxies' capabilities to rewrite URLs #1227

Open
Acconut opened this issue Dec 20, 2024 · 0 comments
Open

Use proxies' capabilities to rewrite URLs #1227

Acconut opened this issue Dec 20, 2024 · 0 comments

Comments

@Acconut
Copy link
Member

Acconut commented Dec 20, 2024

We currently instruct users who operate tusd behind a proxy to setup the proxy to include the original host and scheme in the forwarded requests (https://tus.github.io/tusd/getting-started/configuration/#proxies), so that tusd can generate absolute URLs that include the hostname of the proxy. These URLs are then sent in the Location headers in responses.

However, some proxies automatically rewrite the Location header to match the proxy' address. For example, Nginx does this by default through the proxy_redirect directive: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_redirect

We should look into whether other proxies (HAProxy, Apache, Caddy etc) offer similar capabilities and if we should update our recommendation on forwarding proxy information. Maybe this is not necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant