Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better package name for gRPC proto package #1189

Open
Acconut opened this issue Sep 18, 2024 · 0 comments
Open

Better package name for gRPC proto package #1189

Acconut opened this issue Sep 18, 2024 · 0 comments
Labels
breaking change Backwards compatibility breaking change bug
Milestone
v3

Comments

@Acconut
Copy link
Member

Acconut commented Sep 18, 2024

In #976, the proto's package was accidentally renamed from the already bad name v2 to the even worse name proto: ad074c8#diff-10f75d15f6edc72b2a60a954b02881a0239e0c384353b97e5f485d4a6f527469R9

This means that the example in examples/hooks/grpc doesn't work anymore because it's using the old v2 name.

In addition, for the next major release, I would like to rename the package to something more sensible. Maybe tusd?
@Acconut Acconut added bug breaking change Backwards compatibility breaking change labels Sep 18, 2024
@Acconut Acconut added this to the v3 milestone Sep 18, 2024
Acconut added a commit that referenced this issue Sep 19, 2024
@Acconut
examples: Fix gRPC server
9b86376 
Addresses part of #1189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Backwards compatibility breaking change bug
Projects
None yet
Milestone
v3
Development

No branches or pull requests
1 participant
@Acconut