chore: codefmt

Author: KKould

core/translate/emitter.rs

@@ -1090,7 +1090,7 @@ fn open_loop(
                     if !try_index_cover(
                         program,
                         related_columns,
-                        &table_reference,
+                        table_reference,
                         index_cursor_id,
                         table_cursor_id,
                     ) {
@@ -1172,15 +1172,16 @@ fn try_index_cover(
             index_column_map.insert(pos, index_column_map.len());
         }
 
-        let len = table.columns.len();
         let lower = ColumnBinding {
             table: *table_index,
             column: 0,
         };
-
+        let upper = ColumnBinding {
+            table: table_index + 1,
+            column: 0,
+        };
         let is_cover = related_columns
-            .range(lower..)
-            .take(len)
+            .range(lower..upper)
             .all(|binding| index_column_map.contains_key(&binding.column));
         if is_cover {
             program

core/translate/expr.rs

@@ -1976,20 +1976,19 @@ pub fn translate_expr(
                             column: columns_mapping[column],
                             dest: target_register,
                         });
+                    } else if *is_rowid_alias {
+                        program.emit_insn(Insn::RowId {
+                            cursor_id,
+                            dest: target_register,
+                        });
                     } else {
-                        if *is_rowid_alias {
-                            program.emit_insn(Insn::RowId {
-                                cursor_id,
-                                dest: target_register,
-                            });
-                        } else {
-                            program.emit_insn(Insn::Column {
-                                cursor_id,
-                                column: *column,
-                                dest: target_register,
-                            });
-                        }
+                        program.emit_insn(Insn::Column {
+                            cursor_id,
+                            column: *column,
+                            dest: target_register,
+                        });
                     }
+
                     let column = tbl_ref.table.get_column_at(*column);
                     maybe_apply_affinity(column.ty, target_register, program);
                     Ok(target_register)

core/translate/optimizer.rs

@@ -846,10 +846,10 @@ fn one_select_related_columns(
                 }
             }
             if let Some(from) = from {
-                from_clause_related_columns(&from, related_columns, referenced_tables)?;
+                from_clause_related_columns(from, related_columns, referenced_tables)?;
             }
             if let Some(expr) = where_clause {
-                expr_related_columns(&expr, related_columns, referenced_tables)?;
+                expr_related_columns(expr, related_columns, referenced_tables)?;
             }
             if let Some(group_by) = group_by {
                 for expr in group_by.exprs.iter() {
@@ -861,7 +861,7 @@ fn one_select_related_columns(
             }
             if let Some(windows) = window_clause {
                 for window in windows.iter().map(|window| &window.window) {
-                    window_related_columns(&window, related_columns, referenced_tables)?;
+                    window_related_columns(window, related_columns, referenced_tables)?;
                 }
             }
         }

core/vdbe/mod.rs

@@ -1840,7 +1840,7 @@ impl Program {
     }
 
     #[inline]
-    fn deferred_seek<'a>(
+    fn deferred_seek(
         deferred_seek: &mut Option<(CursorID, CursorID)>,
         cursors: &mut BTreeMap<CursorID, Box<dyn Cursor>>,
     ) -> Result<bool> {