Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nyrkiö Github action fails due to missing index.js file #304

Closed
penberg opened this issue Jan 20, 2025 · 3 comments · Fixed by tursodatabase/limbo#762
Closed

Nyrkiö Github action fails due to missing index.js file #304

penberg opened this issue Jan 20, 2025 · 3 comments · Fixed by tursodatabase/limbo#762

Comments

@penberg
Copy link

penberg commented Jan 20, 2025

I have Nyrkiö configured in my Github workflow:

tursodatabase/limbo@eeffe10

(Had to patch it with tursodatabase/limbo@02b8fb8 btw)

However, the Nyrkiö Github action fails as follows:

Error: File not found: '/home/runner/work/_actions/nyrkio/github-action-benchmark/ec6fe57d80fd83c83c10c6ef3f53899ce993aebb/dist/src/index.js'

Full logs here:

https://github.com/tursodatabase/limbo/actions/runs/12862596384/job/35857760160
@henrikingo
Copy link
Collaborator

I looked at it a little already. The problem is that it didn't run "npm run build" first.

I'm looking into why that is / where to add it back.

One possible explanation is that in the upstream repo one of the demos is to benchmark something in JavaScript (benchmarkJS) and it could be that the entire thing depends on that demo.

@penberg
Copy link
Author

penberg commented Jan 20, 2025

LOL, I did not realize you can close issue from other repositories! @henrikingo please re-open this, Github is just being drunk...

@henrikingo henrikingo reopened this Jan 21, 2025
@henrikingo
Copy link
Collaborator

Ok so there were multiple things that didn't actually work. Among the highlights:

  • A Github action can apparently choose between having input parameters available in JavaScript, or a bash shell to install dependencies with npm. I chose to run npm from inside JavaScript.
  • branch name is required in Nyrkiö but apparently considered completely unnecessary information in most GitHub APIs.

I added to the push-only.yml a few more branches for testing purposes. So you can merge it to "add-nyrkio" or "notmain" and it will also rigger itself there.

@henrikingo henrikingo mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Nyrkiö change point detection to 'cargo bench' workflow henrikingo/limbo
2 participants
@penberg @henrikingo