Skip to content

Commit 5c28f96

Browse files
committed
refactor: use getrandom
1 parent 4c8dc2b commit 5c28f96

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

Cargo.lock

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ ordered-multimap = "0.7.1"
3838
sieve-cache = "0.1.4"
3939
sqlite3-parser = "0.11.0"
4040
thiserror = "1.0.61"
41-
rand = "0.8.5"
41+
getrandom = { version = "0.2.15", features = ["js"]}
4242
regex = "1.10.5"
4343

4444
[target.'cfg(not(target_family = "windows"))'.dev-dependencies]

core/expr.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,6 @@ pub fn translate_expr(
359359
if args.is_some() {
360360
anyhow::bail!("Parse error: random function withargumentst");
361361
}
362-
dbg!("random args", &args);
363362
let regs = program.alloc_register();
364363

365364
program.emit_insn(Insn::Function {

core/vdbe.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ use crate::schema::Table;
55
use crate::types::{AggContext, Cursor, CursorResult, OwnedRecord, OwnedValue, Record};
66

77
use anyhow::Result;
8-
use rand::Rng;
98
use regex::Regex;
109
use std::borrow::BorrowMut;
1110
use std::cell::RefCell;
@@ -1867,8 +1866,9 @@ fn exec_abs(reg: &OwnedValue) -> Option<OwnedValue> {
18671866
}
18681867

18691868
fn exec_random() -> OwnedValue {
1870-
let mut rng = rand::thread_rng();
1871-
let random_number: i64 = rng.gen();
1869+
let mut buf = [0u8; 8];
1870+
getrandom::getrandom(&mut buf).unwrap();
1871+
let random_number = i64::from_ne_bytes(buf);
18721872
OwnedValue::Integer(random_number)
18731873
}
18741874

0 commit comments

Comments
 (0)