Fix turbot_policy_pack_attachment to parse the ID correctly while reading the policy pack. Closes #181 (#182)

Subhajit97 · web-flow · commit 462be95c566c · 2024-09-20T14:21:20.000+05:30
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 1.11.2 (September 20, 2024)
+
+BUG FIXES:
+
+* `resource/turbot_policy_pack_attachment`: terraform apply failed to detect existing Policy Pack attachments. ([#181](https://github.com/turbot/terraform-provider-turbot/issues/181))
+
 ## 1.11.1 (July 15, 2024)
 
 DOCUMENTATION:
diff --git a/scripts/generate-dev-overrides.sh b/scripts/generate-dev-overrides.sh
diff --git a/turbot/resource_turbot_policy_pack_attachment.go b/turbot/resource_turbot_policy_pack_attachment.go
@@ -135,8 +135,9 @@ func buildPolicyPackId(policyPack, resource string) string {
 }
 
 func parsePolicyPackId(id string) (policyPack, resource string) {
-	segments := strings.Split(id, "_")
-	policyPack = segments[0]
-	resource = segments[1]
+	// Get the index of the first underscore
+	index := strings.Index(id, "_")
+	policyPack = id[:index]
+	resource = id[index+1:]
 	return
 }

Original file line number	Diff line number	Diff line change
`@@ -135,8 +135,9 @@ func buildPolicyPackId(policyPack, resource string) string {`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`func parsePolicyPackId(id string) (policyPack, resource string) {`
`138`		`- segments := strings.Split(id, "_")`
`139`		`- policyPack = segments[0]`
`140`		`- resource = segments[1]`
	`138`	`+ // Get the index of the first underscore`
	`139`	`+ index := strings.Index(id, "_")`
	`140`	`+ policyPack = id[:index]`
	`141`	`+ resource = id[index+1:]`
`141`	`142`	`return`
`142`	`143`	`}`