Skip to content

Commit ba33c18

Browse files
Remove redundant installation nil-check in detectLocalPlugin; installation is never nil
1 parent f569060 commit ba33c18

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

internal/plugin/installation_actions.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,6 @@ func List(ctx context.Context, pluginVersions map[string]*versionfile.InstalledV
116116
// detectLocalPlugin returns true if the modTime of the `pluginBinary` is after the installation date as recorded in the installation data
117117
// this may happen when a plugin is installed from the registry, but is then compiled from source
118118
func detectLocalPlugin(installation *versionfile.InstalledVersion, pluginBinary string) bool {
119-
// TODO this should no longer be necessary as we now have a "local" version number in the versions file? https://github.com/turbot/tailpipe/issues/507
120-
if installation == nil {
121-
return true
122-
}
123119
installDate, err := time.Parse(time.RFC3339, installation.InstallDate)
124120
if err != nil {
125121
log.Printf("[WARN] could not parse install date for %s: %s", installation.Name, installation.InstallDate)

0 commit comments

Comments
 (0)