[issue] Shows bug with empty tuple promotion #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RDL has a notion of "raw" generic types where the parameters are not instantiated. I'm surprised that [] is getting promoted to Array<%bot>. It really should be staying as just Array, I think, and then the each call should somehow ignore the parameters. I suspect this idea I have about how this should work is not actually fully implemented. I have a feeling it worked in a version a while back but then probably got broken in this way when I beefed up support for generics. I'll try to take a look and think about how this should be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into this bug in production and I'm not too sure how to fix it. The
:sendpromotes the[]toArray<%bot>and then iterates over the%bot, but in this case it would never enter the block so it should just skip over checking it with an empty tuple. (Our case was obviously more complex but I boiled it down here)