Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: remove RouterProvider from tuono exports #252

Closed
marcalexiei opened this issue Dec 23, 2024 · 1 comment · Fixed by #337
Closed

[Feature request]: remove RouterProvider from tuono exports #252

marcalexiei opened this issue Dec 23, 2024 · 1 comment · Fixed by #337
Assignees
Labels
good first issue Good for newcomers typescript Requires typescript knowledge

Comments

@marcalexiei
Copy link
Member

Referring to:

export {
createRoute,
createRootRoute,
createRouter,
Link,
RouterProvider,
dynamic,
useRouter,
__tuono__internal__lazyLoadComponent,
} from 'tuono-router'

RouterProvider should not be re-exported from tuono npm package.
This component should only be used internally by the tuono package and should not be available for external use.

@marcalexiei marcalexiei added the typescript Requires typescript knowledge label Dec 23, 2024
@marcalexiei marcalexiei moved this to Ready in Road to V1 Dec 23, 2024
@Valerioageno Valerioageno added the good first issue Good for newcomers label Jan 12, 2025
@jacobhq
Copy link
Contributor

jacobhq commented Jan 13, 2025

Happy to handle this in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers typescript Requires typescript knowledge
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants