Buffer.Clone() should avoid bit-shifting.

tunabay · tunabay · commit a999acd99c45 · 2021-09-21T22:47:04.000+09:00
diff --git a/buffer.go b/buffer.go
@@ -92,10 +92,10 @@ func (buf *Buffer) Clone() *Buffer {
 	if buf.Len() == 0 {
 		return &Buffer{}
 	}
-	b := allocByteSlice((buf.nBits + 7) >> 3)
-	copyBits(b, buf.b, 0, buf.off, buf.nBits)
+	b := make([]byte, len(buf.b))
+	copy(b, buf.b)
 
-	return &Buffer{b: b, nBits: buf.nBits}
+	return &Buffer{b: b, nBits: buf.nBits, off: buf.off}
 }
 
 // BitArray creates an imuurable BitArray from the current content.

Original file line number	Diff line number	Diff line change
`@@ -92,10 +92,10 @@ func (buf Buffer) Clone() Buffer {`
`92`	`92`	`if buf.Len() == 0 {`
`93`	`93`	`return &Buffer{}`
`94`	`94`	`}`
`95`		`- b := allocByteSlice((buf.nBits + 7) >> 3)`
`96`		`- copyBits(b, buf.b, 0, buf.off, buf.nBits)`
	`95`	`+ b := make([]byte, len(buf.b))`
	`96`	`+ copy(b, buf.b)`
`97`	`97`
`98`		`- return &Buffer{b: b, nBits: buf.nBits}`
	`98`	`+ return &Buffer{b: b, nBits: buf.nBits, off: buf.off}`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`// BitArray creates an imuurable BitArray from the current content.`