Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Rename 'pos' to something more meaningful #533

Open
christophKaiser opened this issue Mar 3, 2022 · 0 comments
Open

[REF] Rename 'pos' to something more meaningful #533

christophKaiser opened this issue Mar 3, 2022 · 0 comments
Labels
IFC Content related to Industry Foundation Classes (IFC) functionalities quality_of_life Nice to have improvement refactoring Code refactoring related task

Comments

@christophKaiser
Copy link
Collaborator

The parameter name pos is used in many functions of the geometry converter. It describes the transformation of the geometry coordinates to place an object in its place. A change request brought up that the parameter name does not really fit.

In the discussion and in a dev-meeting, the suggestion objectPlacement was decided to be a more meaningful name.

File which is being refactored
Many files in the namespace IfcGeometryConverter.

Functions
Basically, all functions in the IfcGeometryConverter could be affected and should be checked (at least with the auto-search/-replacement tool).

@christophKaiser christophKaiser added IFC Content related to Industry Foundation Classes (IFC) functionalities refactoring Code refactoring related task quality_of_life Nice to have improvement labels Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IFC Content related to Industry Foundation Classes (IFC) functionalities quality_of_life Nice to have improvement refactoring Code refactoring related task
Projects
None yet
Development

No branches or pull requests

1 participant