Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night set-back timestep-wise checked #4

Open
sonercandas opened this issue Feb 22, 2023 · 0 comments
Open

Night set-back timestep-wise checked #4

sonercandas opened this issue Feb 22, 2023 · 0 comments
Assignees

Comments

@sonercandas
Copy link

If I understand correctly, whether a building has a night set-back temperature for space heating is checked on a timestep-basis (per iii), not building-basis:

	`# Night set-back
	# From 23:00 to 6:00 temperature is lowered to 18degC
	# check if building has night set-back
	rand_num = np.random.uniform(0, 1, 1)
	if (rand_num < self._night_set_back):
		
		# check night-set-back hours
		if self.dt_vector[iii].hour >= self.schedule_nsb[0] or self.dt_vector[iii].hour < self.schedule_nsb[1]:
			# set Tset at Tnight_set_back
			self.Tset = self.T_nsb		`

which doesn't make sense, right? If you agree, I can provide a fix that checks the option for each building once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants