flake: add package for Nix #600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumnerevans
reviewed
Feb 28, 2025
|
|
||
| src = ./.; | ||
|
|
||
| # Go dependency hash (should be updated when dependencies are) |
There was a problem hiding this comment.
The reason I didn't add a package to the flake was because of this. I don't want to have to make a PR every time we update dependencies.
There was a problem hiding this comment.
I would say, small price to pay, or maybe it'd even be possible to update this in the same commit when updating dependencies (though, of course, that puts more work on Tulir). If that is unacceptable - a quick search lead me to gomod2nix, which might not have this requirement.(?)
There was a problem hiding this comment.
Tulir doesn't use nix. I know from experience that it is very annoying to manage the vendor hash even when using nix. I forget to update the hash consistently on my own projects.
…uks#629) Limits the height of the room name to 6rem and provides a y-scroll for names that exceed the height limit. Prevents invited rooms hiding the reject button
Renaming (aka moving) a temporary file evidently does not seem to work on Windows when there is an open filehandle. This leads to all user and space avatars remaining blank as temporary files could not be moved to the cache. Simply closing the file before moving should make Windows behave (Linux had always just worked)
Modern browsers should only use .woff2 and .ogg, gomuks web doesn't support outdated browsers anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it nicer to build & run gomuks with Nix. One can now just
nix run.