Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware status on Hero is not monitored. #1078

Open
PetervDooren opened this issue Feb 16, 2021 · 1 comment
Open

Hardware status on Hero is not monitored. #1078

PetervDooren opened this issue Feb 16, 2021 · 1 comment
Labels
Low Priority Not super important. But should be done at some point maintenance Making existing code better in terms of style and setup requires robot This can only be worked on with access to the lab

Comments

@PetervDooren
Copy link
Contributor

tue_robocup/robot_skills/src/robot_skills/hero.py

Lines 60 to 63 in 73b9ad1

# These don't work for HSR because (then) Toyota's diagnostics aggregator makes the robot go into error somehow
for part in self.parts.itervalues():
part.unsubscribe_hardware_status()
part._operational = True

We should try to fix this so that we can get proper diagnostics of our robot.
@PetervDooren PetervDooren added Low Priority Not super important. But should be done at some point maintenance Making existing code better in terms of style and setup requires robot This can only be worked on with access to the lab labels Feb 16, 2021
@MatthijsBurgh
Copy link
Member

We do have the diagnostics of Toyota, it is just not in the robot_skills layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low Priority Not super important. But should be done at some point maintenance Making existing code better in terms of style and setup requires robot This can only be worked on with access to the lab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatthijsBurgh @PetervDooren