-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store/publish objects in frame of supporting object #58
Comments
Everything is stored w.r.t. the map frame so I don't know what you mean with "publish". How to publish if this information is not present? I do think it is more logical to store entities w.r.t. their supporting objects but the current implementation of ED does not allow this. Properly implementing relative positions is going to be a lot of work and requires a lot of re-implementation of functionalities. We have done this in the past so if you are interested in doing this work, I can point you in the right direction. There are already pose crawlers etc. implemented. |
I do mean store. Let's have a short talk about this tomorrow. Then we can decide if this could be a side project. |
I agree with the idea. It feels more 'correct' to do something like that. The thought crossed my mind a few times as well. Let's talk about it tomorrow. |
In principle, this seems to make (much more) sense. Two comments:
Anyway, didn't hear this discussion yesterday but might be good to do this in the near future |
Question remains: is there an issue here? It's a lot of work just to check if it improves anything. So we should know that it is worth the effort. Also, there are other bugs in the association. I'm pretty sure of that. Maybe we should fix those first? |
I already labeled the issue as an enhancement. I do have seen some problems with the association during testing last week. But I don't have the knowledge to know what is the low hanging fruit. |
This would reduce the displacement of objects when a supporting object is moved. Thus reduce errors in association of objects.
@reinzor
@jlunenburg
@rokusottervanger
What do you think?
The text was updated successfully, but these errors were encountered: