Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation of intersection between more than 2 faces #11

Open
Ylannl opened this issue Nov 2, 2021 · 2 comments
Open

Computation of intersection between more than 2 faces #11

Ylannl opened this issue Nov 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Ylannl
Copy link
Member

Ylannl commented Nov 2, 2021

Is this correct?

https://github.com/liberostelios/urban-morphology-3d/blob/fba6e83a773ca6948438d85c6277226bc83406c5/geometry.py#L184-L185

In most cases len(polys)==2, but if len(polys)>2 wouldn't these lines give the wrong intersection result?

@liberostelios
Copy link
Collaborator

In theory not, because this calculation is done in a per plane base, so there can be more than two polygons that are on the same plane and need to be intersected. Think of two buildings, one having a long polygon on one side and the other one touching it at two different polygons on the other side.

I think that's the case, here. Unless I am missing something.

@liberostelios
Copy link
Collaborator

Just realised you are right, actually. At the first intersection, we already lost the rest of the polygon. This needs to be implemented in a way that all possible intersections are taken into account.

@liberostelios liberostelios added the bug Something isn't working label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants