Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not that easy to install in a Github action? #647

Open
kaihendry opened this issue Sep 12, 2023 · 4 comments
Open

Not that easy to install in a Github action? #647

kaihendry opened this issue Sep 12, 2023 · 4 comments

Comments

@kaihendry
Copy link

Question

I can't see an easy and straightforward way to install vegeta in a Github action.

https://github.com/search?q=%22install%22+%22vegeta%22+path%3A.github%2Fworkflows&type=code shows awkward examples of downloading the tarball and extracting it. Surely there is an easier way!?

@tsenart
Copy link
Owner

tsenart commented Sep 12, 2023

There are a number of packages from Linux distros. Downloading the tarball would be the second easiest. What you want is an actual GitHub action for vegeta or a Docker image, but we don't have that yet. There might be unofficial ones.

@kaihendry
Copy link
Author

What about go install github.com/tsenart/vegeta@latest?

Sidenote: I used vegeta to try understand what the trade off is of proxying requests. Can plots be overlayed I wonder? https://github.com/kaihendry/turtles/actions/runs/6158560901

@tsenart
Copy link
Owner

tsenart commented Sep 12, 2023

What about go install github.com/tsenart/vegeta@latest?

That's not recommended. If you want to build it yourself you can clone and run make vegeta.

Yes, vegeta plot can take multiple result files. Just be sure to set a different -name in each of your attacks.

kaihendry added a commit to kaihendry/turtles that referenced this issue Sep 12, 2023
@kaihendry
Copy link
Author

Why is it not recommended to install via the canonical Go install method?

Not sure you can see https://github.com/kaihendry/turtles/actions/runs/6159497649 artefact, it's hard to filter the top layer of points and I don't understand the "OK" in your UI. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants