Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress semVerCompare logic does not work for eks #56

Open
45cali opened this issue Jun 2, 2022 · 2 comments
Open

ingress semVerCompare logic does not work for eks #56

45cali opened this issue Jun 2, 2022 · 2 comments

Comments

@45cali
Copy link

45cali commented Jun 2, 2022

https://github.com/tryretool/retool-helm/blob/main/templates/ingress.yaml#L5-L11

eks adds -eks-<some more stuff> to the version of eks

 k version                                                                                                                                                                                                                                     <aws:pii-dev-/devops_team>
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.0", GitCommit:"af46c47ce925f4c4ad5cc8d1fca46c7b77d13b38", GitTreeState:"clean", BuildDate:"2020-12-08T17:59:43Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.16-eks-25803e", GitCommit:"25803e8d008d5fa99b8a35a77d99b705722c0c8c", GitTreeState:"clean", BuildDate:"2022-02-16T23:37:16Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}

so we end up with apiVersion: extensions/v1beta1 instead of networking.k8s.io/v1 for our ingress apiVersion

@45cali
Copy link
Author

45cali commented Jun 6, 2022

also just found out this prevents us from setting ingress class name too

{{- if and .Values.ingress.ingressClassName (semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion) }}
ingressClassName: {{ .Values.ingress.ingressClassName }}

@asaf400
Copy link

asaf400 commented May 21, 2023

I've created a PR to fix this: #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants