Skip to content

Commit d5ed79f

Browse files
committed
fix fatal error when attempting to cancel a cancelled Stripe subscription
1 parent 50254ac commit d5ed79f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/main/java/com/trynoice/api/subscription/SubscriptionService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ private void handleStripeCheckoutSessionEvent(@NonNull Session session) throws W
570570
try {
571571
stripeApi.refundSubscription(session.getSubscription());
572572
} catch (StripeException e) {
573-
throw new RuntimeException("failed to cancel stripe subscription", e);
573+
throw new RuntimeException("failed to refund stripe subscription", e);
574574
}
575575
} else {
576576
copySubscriptionDetailsFromStripeObject(subscription);

src/main/java/com/trynoice/api/subscription/upstream/StripeApi.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,9 @@ public void refundSubscription(@NonNull String id) throws StripeException {
159159
}
160160
}
161161

162-
subscription.cancel();
162+
if (!"canceled".equals(subscription.getStatus())) {
163+
subscription.cancel();
164+
}
163165
}
164166

165167
/**

0 commit comments

Comments
 (0)