Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor metrics initializer #188

Open
covain opened this issue Nov 8, 2022 · 1 comment
Open

Refactor metrics initializer #188

covain opened this issue Nov 8, 2022 · 1 comment
Assignees
@nikoskarakostas
Labels
enhancement New feature or request

Comments

@covain
Copy link
Collaborator

covain commented Nov 8, 2022

Make labels var optional so it doesn't require passing nil.
https://github.com/trustwallet/go-libs/blob/master/metrics/metrics.go#L32
@covain covain added the enhancement New feature or request label Nov 8, 2022
@covain covain assigned nikoskarakostas and unassigned DeimonDB Jan 3, 2023
@ngqinzhe ngqinzhe mentioned this issue Mar 21, 2024
Open
@ngqinzhe
Copy link

@covain can I try this refactoring? please help to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikoskarakostas nikoskarakostas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DeimonDB @nikoskarakostas @ngqinzhe @covain