Enable optional symlink following for fs source #4565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
reviewed
Nov 20, 2025
Comment on lines
98
to
105
| cleanPath := filepath.Clean(path) | ||
| fileInfo, err := os.Lstat(cleanPath) | ||
| var fileInfo fs.FileInfo | ||
| var err error | ||
| if s.followSymlinks { | ||
| fileInfo, err = os.Stat(cleanPath) | ||
| } else { | ||
| fileInfo, err = os.Lstat(cleanPath) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggestion: I think this can be simplified via filepath.EvalSymlinks:
cleanPath := filepath.Clean(path)
if s.followSymlinks {
var err error
cleanPath, err = filepath.EvalSymlinks(path)
if err != nil { /* ... */ }
}
mcastorina
reviewed
Nov 20, 2025
| } | ||
|
|
||
| if fileInfo.Mode()&os.ModeSymlink != 0 { | ||
| if !s.followSymlinks && fileInfo.Mode()&os.ModeSymlink != 0 { |
Contributor
There was a problem hiding this comment.
fileInfo.Mode() would always be non-symlink if os.Stat is used, right? Since Stat follows symlinks.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds an option to follow symlinks in the fs source.
Checklist:
make test-community)?make lintthis requires golangci-lint)?