Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Snowflake unit tests #3822

Open
rgmz opened this issue Dec 29, 2024 · 0 comments
Open

Flaky Snowflake unit tests #3822

rgmz opened this issue Dec 29, 2024 · 0 comments
Labels

Comments

@rgmz
Copy link
Contributor

rgmz commented Dec 29, 2024

The Snowflake unit tests are flaky and periodically fail:

--- FAIL: TestSnowflake_Pattern (0.01s)
    --- FAIL: TestSnowflake_Pattern/Snowflake_Credentials (0.01s)
        snowflake_test.go:70: did not receive result
    --- FAIL: TestSnowflake_Pattern/Private_Snowflake_Credentials (0.00s)
        snowflake_test.go:70: did not receive result
    --- FAIL: TestSnowflake_Pattern/Snowflake_Credentials_-_Single_Character_account (0.00s)
        snowflake_test.go:70: did not receive result
FAIL
FAIL	github.com/trufflesecurity/trufflehog/v3/pkg/detectors/snowflake	0.618s

This is presumably due to the use of brianvoe/gofakeit to generate values.

func TestSnowflake_Pattern(t *testing.T) {
username := gofakeit.Username()
password := gofakeit.Password(true, true, true, false, false, 10)


I don't know if these are valid results being missed, or invalid generated values that ought to be skipped.

@rgmz rgmz added the bug label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant