Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gemini models #402

Open
mnvsk97 opened this issue Nov 1, 2024 · 5 comments
Open

Add support for Gemini models #402

mnvsk97 opened this issue Nov 1, 2024 · 5 comments
Labels
enhancement New feature or request llm integration

Comments

@mnvsk97
Copy link
Contributor

mnvsk97 commented Nov 1, 2024

  • Models and providers should be configurable from models_config.yaml
  • Add support to inference servers that are not OpenAI compatible.
@mnvsk97 mnvsk97 added llm integration enhancement New feature or request labels Nov 5, 2024
@AbhishekRP2002
Copy link
Contributor

hi @mnvsk97 if this is not taken up yet by anyone, I would love to take this up and contribute.

  • I think for the first point we have to update model_gateway.py and model_config.sample.yaml
  • for the second one, can u please explain a little more ?

@AbhishekRP2002
Copy link
Contributor

any updates on this ? @mnvsk97

cc: @chiragjn

@AbhishekRP2002
Copy link
Contributor

Hi @mnvsk97 @chiragjn please lemme know if this enhancement is still in the roadmap.
Would be super grateful if given the chance to contribute

@chiragjn
Copy link
Member

chiragjn commented Jan 17, 2025

Hey @AbhishekRP2002 , sorry I didn't get chance to reply earlier.
I am wondering, now that Gemini has a openai compatible API (https://ai.google.dev/gemini-api/docs/openai), is this still needed?


I know accessing Gemini without API Key via some service account will need separate work

@AbhishekRP2002
Copy link
Contributor

Hey @AbhishekRP2002 , sorry I didn't get chance to reply earlier. I am wondering, now that Gemini has a openai compatible API (https://ai.google.dev/gemini-api/docs/openai), is this still needed?

I know accessing Gemini without API Key via some service account will need separate work

yeah u are right actually, i think with Gemini models accessible using the OpenAI lib we don't need to make any changes.
I thought in the direction of using gemini models either via Google AI Studio ( google.generativeai package ) or Vertex AI.
Apologies.
yeah for service account we need the GOOGLE_APPLICATIONS_CREDENTIALS with authentication via google auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request llm integration
Projects
None yet
Development

No branches or pull requests

3 participants