Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing access point at road / stream crossings #133

Open
WilBublitz opened this issue Aug 23, 2018 · 3 comments
Open

Missing access point at road / stream crossings #133

WilBublitz opened this issue Aug 23, 2018 · 3 comments
Labels

Comments

@WilBublitz
Copy link

Issue Description:

Bridge crossing at road + stream intersection 47.063570, -115.218954 does not appear as an access point.

Expected Results:

road + stream crossing appears as clickable access point

Steps to Reproduce:

Navigate to Troutspotr.
Locate http://localhost:3000/id/north/heller-creek on map
Find road at intersection with http://localhost:3000/id/north/sherlock-creek
Confirm that access point appears and is clickable.

@andest01
Copy link
Collaborator

image

Both road and creek do appear to be present in raw data.

On closer inspection, we appear to have duplicate roads present.
image

This may be cause for concern.

@andest01
Copy link
Collaborator

The access point is indeed in our data set.
image

Investigating why it's not present.

@andest01
Copy link
Collaborator

andest01 commented Aug 23, 2018

Data is present in client TopoJSON. This is good.

image

However, due to a bug much deeper in the back-end TopoJSON generator, the distance_to_previous_neighbor property is 0.

Adding a new issue to fix the deeper backend bug. For now, a potential hack would be to say we only filter out "duplicate" roads if they are "extremely close" AND their distance to their neighbors is more than literally zero.

In Northern Idaho alone, this fix opens up 236 new access points.
image

@WilBublitz what do you think? Go forward with the hacky fix to get more access points?

andest01 added a commit that referenced this issue Aug 23, 2018
… there are actual duplicate 0-distance aps. See Heller Creek, ID for more.
andest01 added a commit that referenced this issue Aug 23, 2018
… there are actual duplicate 0-distance aps. See Heller Creek, ID for more. (#137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants