fix the bug of concurrent usage of toString in TransactionCapsule (#5696

)
tronprotocol · Jan 26, 2024 · cbf2417 · cbf2417
1 parent baddd4f
commit cbf2417
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/chainbase/src/main/java/org/tron/core/capsule/TransactionCapsule.java b/chainbase/src/main/java/org/tron/core/capsule/TransactionCapsule.java
@@ -102,7 +102,6 @@ public class TransactionCapsule implements ProtoCapsule<Transaction> {
   @Setter
   private TransactionTrace trxTrace;
 
-  private StringBuilder toStringBuff = new StringBuilder();
   @Getter
   @Setter
   private long time;
@@ -738,7 +737,7 @@ public Transaction getInstance() {
 
   @Override
   public String toString() {
-
+    StringBuilder toStringBuff = new StringBuilder();
     toStringBuff.setLength(0);
     toStringBuff.append("TransactionCapsule \n[ ");
 

diff --git a/framework/src/test/java/org/tron/core/actuator/utils/TransactionUtilTest.java b/framework/src/test/java/org/tron/core/actuator/utils/TransactionUtilTest.java
@@ -14,6 +14,7 @@
 
 import com.google.protobuf.ByteString;
 import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
 import java.util.List;
 import lombok.extern.slf4j.Slf4j;
 import org.junit.Assert;
@@ -431,4 +432,22 @@ public void estimateConsumeBandWidthSizeCorner() {
     long actual = TransactionUtil.estimateConsumeBandWidthSize(dps, balance);
     Assert.assertEquals(expected, actual);
   }
+
+  @Test
+  public void testConcurrentToString() throws InterruptedException {
+    Transaction.Builder builder = Transaction.newBuilder();
+    TransactionCapsule trx = new TransactionCapsule(builder.build());
+    List<Thread> threadList = new ArrayList<>();
+    int n = 10;
+    for (int i = 0; i < n; i++) {
+      threadList.add(new Thread(() -> trx.toString()));
+    }
+    for (int i = 0; i < n; i++) {
+      threadList.get(i).start();
+    }
+    for (int i = 0; i < n; i++) {
+      threadList.get(i).join();
+    }
+    Assert.assertTrue(true);
+  }
 }