-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternative element-local mapping #34
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 81.78% 82.31% +0.53%
==========================================
Files 8 8
Lines 829 854 +25
==========================================
+ Hits 678 703 +25
Misses 151 151 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @tristanmontoya! I've just left a minor request for a more detailed description of the new strategy in the docstring.
This PR adds the element-local mapping from Guba et al. (2014), which first maps the quadrature node coordinates from the reference element using a bilinear mapping based on the four corner vertices, and then projects the mapped nodes onto a sphere of radius$a$ by scaling the resulting Cartesian coordinates $\boldsymbol{x}$ by $a/\lVert\boldsymbol{x} \rVert_2$ . This is a quadrilateral version of what Michael Baldauf does for triangular grids (e.g. in this paper).