Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative element-local mapping #34

Merged
merged 11 commits into from
Nov 6, 2024
Merged

Conversation

tristanmontoya
Copy link
Member

@tristanmontoya tristanmontoya commented Sep 10, 2024

This PR adds the element-local mapping from Guba et al. (2014), which first maps the quadrature node coordinates from the reference element using a bilinear mapping based on the four corner vertices, and then projects the mapped nodes onto a sphere of radius $a$ by scaling the resulting Cartesian coordinates $\boldsymbol{x}$ by $a/\lVert\boldsymbol{x} \rVert_2$. This is a quadrilateral version of what Michael Baldauf does for triangular grids (e.g. in this paper).

@tristanmontoya tristanmontoya marked this pull request as draft September 10, 2024 15:07
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (ba74a0b) to head (ece11a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...olvers/dgsem_p4est/containers_2d_manifold_in_3d.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   81.78%   82.31%   +0.53%     
==========================================
  Files           8        8              
  Lines         829      854      +25     
==========================================
+ Hits          678      703      +25     
  Misses        151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tristanmontoya tristanmontoya marked this pull request as ready for review September 10, 2024 15:24
@tristanmontoya tristanmontoya changed the title Add alternative element-local mapping Add alternative element-local mapping (to be merged before #31) Sep 14, 2024
Copy link
Collaborator

@amrueda amrueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @tristanmontoya! I've just left a minor request for a more detailed description of the new strategy in the docstring.

src/meshes/p4est_cubed_sphere.jl Outdated Show resolved Hide resolved
@tristanmontoya tristanmontoya changed the title Add alternative element-local mapping (to be merged before #31) Add alternative element-local mapping Nov 6, 2024
@tristanmontoya tristanmontoya merged commit 3b6f7c1 into main Nov 6, 2024
10 checks passed
@tristanmontoya tristanmontoya deleted the tm/element_local_mapping branch November 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants