-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-conservative mortars for P4estMesh 3D #2127
base: main
Are you sure you want to change the base?
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 477 477
Lines 37753 37760 +7
=======================================
+ Hits 36378 36385 +7
Misses 1375 1375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It seems like the parabolic solver is attempting to use the |
I think I tracked down the issue. On |
Thanks for checking, Andrew. I wonder why this issue is only showing in this PR. I only changed the name of the variable fstar. 🤔 |
Good spot, I do not really recall why this was implemented in this way in |
A unique mortar flux used to be computed from the small interfaces and then projected to the big elements and copied to the small elements. This works for conservation laws. However, for non-conservative equations, the mortar flux should be computed from both sides of the mortar due to its asymmetric nature.