Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence on Octavian.jl for Julia 1.11 #1906

Open
jlchan opened this issue Apr 16, 2024 · 1 comment
Open

Remove dependence on Octavian.jl for Julia 1.11 #1906

jlchan opened this issue Apr 16, 2024 · 1 comment
Labels
upstream

Comments

@jlchan
Copy link
Contributor

jlchan commented Apr 16, 2024

With LoopVectorization.jl being deprecated in Julia v1.11, this also means Octavian.jl is being deprecated.

DGMulti depends on Octavian.jl's matmul! routine; this should be replaced with LinearAlgebra.mul! for 1.11.
@sloede sloede mentioned this issue Apr 24, 2024
Open
This was referenced May 22, 2024
Open
Merged
@jlchan
Copy link
Contributor Author

jlchan commented Jul 25, 2024

Note to self: if we remove Octavian.jl, we can also simplify some of the mul_by! routines. Right now, we special-case mul_by! for UniformScaling and some other types to get around matmul! restrictions. If we drop matmul! for mul!, this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlchan @ranocha