Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bold/italic/etc formatting removed from all server messages #382

Closed
diogotcorreia opened this issue Feb 1, 2024 · 0 comments · Fixed by #383
Closed

Bold/italic/etc formatting removed from all server messages #382

diogotcorreia opened this issue Feb 1, 2024 · 0 comments · Fixed by #383
Assignees
@diogotcorreia
Labels
module:bungeecord Related to BungeeCord module:spigot Related to Spigot/PaperMC type:bug Something isn't working as expected
Milestone
3.9.5

Comments

@diogotcorreia
Copy link
Member

Because of SpigotMC/BungeeCord#3569, BaseComponent#hasFormatting is returning false when it should not, so Triton did not properly serialize the components.

Triton/core/src/main/java/com/rexcantor64/triton/language/parser/AdvancedComponent.java

Line 51 in 85af643

if (comp.hasFormatting()) {

This will be fixed with SpigotMC/BungeeCord#3611, but it can be fixed on Triton as well by removing this check.
@diogotcorreia diogotcorreia added type:bug Something isn't working as expected module:bungeecord Related to BungeeCord module:spigot Related to Spigot/PaperMC labels Feb 1, 2024
@diogotcorreia diogotcorreia added this to the 3.9.5 milestone Feb 1, 2024
@diogotcorreia diogotcorreia self-assigned this Feb 1, 2024
@diogotcorreia diogotcorreia mentioned this issue Feb 1, 2024
Merged
@github-project-automation github-project-automation bot moved this to Done in Triton Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diogotcorreia diogotcorreia

Labels
module:bungeecord Related to BungeeCord module:spigot Related to Spigot/PaperMC type:bug Something isn't working as expected
Projects
Triton
Status: Done
Milestone
3.9.5
Development

Successfully merging a pull request may close this issue.

fix: workaround misbehaving BaseComponent#hasFormatting tritonmc/Triton
1 participant
@diogotcorreia