Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 Resources to be tested by conditions #12642

Open
TheDog-GH opened this issue Jun 12, 2024 · 5 comments
Open

2.6 Resources to be tested by conditions #12642

TheDog-GH opened this issue Jun 12, 2024 · 5 comments

Comments

@TheDog-GH
Copy link
Contributor

TheDog-GH commented Jun 12, 2024

The ability to test Resources and trigger actions as currently it is very limited.

Apparently a wish for many years, here are a few links
https://forums.triplea-game.org/topic/2617/haveresources-as-a-condition-option
https://forums.triplea-game.org/topic/587/allow-triggers-to-give-multiple-resources

Project Feature Cards
https://github.com/orgs/triplea-game/projects/9/views/1

@WCSumpton @Cernelius

@WCSumpton
Copy link
Contributor

WCSumpton commented Jun 12, 2024

This is actually two different requests. The first is the ability to check the amount of resources available for a given player. The second deals with the many different ways resources are handled. objectiveValue (deals only with PUs), resource and resourceCount, costPUs (deprecated), costResources (replaces costPUs).

I submitted a pull request, haveResources, which would deal with the first feature, but I pulled it down because it was combined with isAI. Also, there was a request for this condition to also check on projected resources.

As to the second feature, there should be a discussion on how to handle these multiple paths. Programming wise, they could all be combined into one method, but you could still have multiple xml options. (costResources, giveResources, etc...). This could also include a way to set resources so that values like "-9999" are not use to zero out a resource.

Cheers...

@TheDog-GH
Copy link
Contributor Author

As you have given it the most time/thought it your call on how to proceed.

If you want to split it in two then do so and will link to it/them.

Shall I take it out of the Top/To Do column for now, until your are ready?

@WCSumpton
Copy link
Contributor

You can leave it for now. I will give status reports on progress. At the moment I'm still working on the AvailableResources project.

Cheers...

@WCSumpton WCSumpton self-assigned this Jun 12, 2024
@WCSumpton
Copy link
Contributor

Speaking of request there support for air battles.

Also I know that we have discussed adding territoryEffects to AA attacks. (Can't find that discussion),

Cheers...

@TheDog-GH
Copy link
Contributor Author

@WCSumpton WCSumpton removed their assignment Jun 22, 2024
@WCSumpton WCSumpton self-assigned this Aug 25, 2024
@WCSumpton WCSumpton removed their assignment Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Top
Development

No branches or pull requests

2 participants