Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 Do not display player in Politics Table, List of players not to show (1of 4) #12636

Open
TheDog-GH opened this issue Jun 11, 2024 · 6 comments

Comments

@TheDog-GH
Copy link
Contributor

TheDog-GH commented Jun 11, 2024

Mapmakers sometimes use dummy players to achieve conditions and triggers like natural disasters/weather of just a special type of Neutral and as the true player cannot interact with them they should not be displayed, to reduce confusion.

This could be a list of Players.

Project Feature Cards
https://github.com/orgs/triplea-game/projects/9/views/1

EDIT: As per Cernelius suggestion below this should be in map.properties

@TheDog-GH TheDog-GH changed the title Test 2.6 New Property? Do not display player in politics Table, List of players not to show Jun 11, 2024
@TheDog-GH TheDog-GH changed the title 2.6 New Property? Do not display player in politics Table, List of players not to show 2.6 Do not display player in politics Table, List of players not to show Jun 11, 2024
@TheDog-GH TheDog-GH changed the title 2.6 Do not display player in politics Table, List of players not to show 2.6 Do not display player in Politics Table, List of players not to show Jun 11, 2024
@WCSumpton
Copy link
Contributor

There is the "isHidden" option of the which is used to not show this player on the select screen. Could this option be expanded to cover Politics, Tech, Player, etc. Or is there some other idea on how to accomplish this. (This can reference #12635 also.)

Cheers...

@TheDog-GH
Copy link
Contributor Author

TheDog-GH commented Jun 11, 2024

@WCSumpton Yes that would work.

I had initially thought it would be a special 'Property' of sorts, with a list of Players that are not shown.

I dont know what would be best

Project Feature Cards
https://github.com/orgs/triplea-game/projects/9/views/1

@Cernelius
Copy link
Contributor

There is the "isHidden" option of the which is used to not show this player on the select screen. Could this option be expanded to cover Politics, Tech, Player, etc. Or is there some other idea on how to accomplish this. (This can reference #12635 also.)

So long as this is not impacting on the rules, I think it belongs to the skin.

To clarify, the "isHidden" option actually has game relevance in that it makes impossible to assign that player. Here, instead, it looks like it is merely a display matter, so it should be handled at a skin level like the map.property "dont_draw_units".

@Cernelius
Copy link
Contributor

Same as above for #12635

@TheDog-GH
Copy link
Contributor Author

TheDog-GH commented Jun 12, 2024

As there are 4 very similar requests they hopefully will all be actioned at the same time?
This one and
#12645
#12635
#12646

so in the map.properties we could have the following?

# On the Politics panel Ctrl+W Do Not Show the following player/factions
# player.doNotShowInPoliticsTable=Gaia:Neutral:none

# On the Players tab Do Not Show the following player/factions
# player.doNotShowInPlayerTable=Gaia:Neutral:none

# On the Players tab, Tech Table Do Not Show the following player/factions
# player.doNotShowInTechTable=Gaia:Neutral:none

# On the Help> Unit help table Do Not Show the following player/factions (Note NULL)
# player.doNotShowInUnitHelp=Gaia:Neutral:none:NULL

Thoughts?

EDIT Added 4th entry

@TheDog-GH TheDog-GH changed the title 2.6 Do not display player in Politics Table, List of players not to show 2.6 Do not display player in Politics Table, List of players not to show (1of 3) Jun 12, 2024
@Cernelius
Copy link
Contributor

Maybe better having a single one for not showing it in Politics, Players and Tech table alike?

Substantially, TripleA is already doing this for the "Neutral" player, so it may be just an option telling the program to treat the players just like the "Neutral" player is currently already treated in any such matters. It could be a list of players thus hidden, with the default being "Neutral" only (if not specified).

@TheDog-GH TheDog-GH changed the title 2.6 Do not display player in Politics Table, List of players not to show (1of 3) 2.6 Do not display player in Politics Table, List of players not to show (1of 4) Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants