Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make client module private #43

Open
findepi opened this issue Sep 9, 2020 · 3 comments
Open

Make client module private #43

findepi opened this issue Sep 9, 2020 · 3 comments

Comments

@findepi
Copy link
Member

findepi commented Sep 9, 2020

rename client to _client.

relates to #41 (comment)

cc @hashhar
@hashhar hashhar self-assigned this Sep 9, 2020
@hashhar
Copy link
Member

hashhar commented Sep 9, 2020

Acknowledged. Will send a PR once #41 is merged to avoid to rebase/conflicts.

@hashhar hashhar mentioned this issue Jan 15, 2021
Merged
@joshthoward
Copy link
Member

@hashhar If we update the public facing API, can we import connection as a peer to the dbapi module? This matches what is done SQLAlchemy and PyODBC and should be able to be done in a backward compatible way.

@findepi
Copy link
Member Author

findepi commented Mar 1, 2021

This is free to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@findepi @joshthoward @hashhar