New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comment creation with sqlalchemy #256

Open

1 task

mdesmet opened this issue Oct 11, 2022 · 0 comments

Contributor

mdesmet commented Oct 11, 2022

Describe the feature

sqlalchemy provides support for comments on Tables and Columns

See https://docs.sqlalchemy.org/en/14/core/metadata.html#sqlalchemy.schema.Table.params.comment
https://docs.sqlalchemy.org/en/14/core/metadata.html#sqlalchemy.schema.Column.params.comment

The Trino implementation currently does not support this.

Describe alternatives you've considered

No response

Are you willing to submit PR?

Yes I am willing to submit a PR!

mdesmet mentioned this issue

Fix 'Engine' object has no attribute 'connection' #255

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment