Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(suite): use SubTabs component for coinmarket navigation #15908

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore(suite): use SubTabs component for coinmarket navigation #15908

merged 1 commit into from
Dec 11, 2024

Conversation

adamhavel
Copy link
Contributor

No description provided.

jvaclavik
jvaclavik approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@jvaclavik jvaclavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, ship it!

@adamhavel adamhavel self-assigned this Dec 11, 2024
@adamhavel adamhavel merged commit ec8062d into develop Dec 11, 2024
25 checks passed
@adamhavel adamhavel deleted the chore/use-subtabs-for-coinmarket-navigation branch December 11, 2024 12:29
@adderpositive
Copy link
Contributor

adderpositive commented Dec 11, 2024 •
edited
Loading

Bugs I found

  • Last transactions will not return to the Swap or Buy & Sell section
  • Entering from Dashboard, then using the back button will not return me to Dashboard, but Account level

The next state should be to implement Trade router. It would be very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvaclavik jvaclavik jvaclavik approved these changes

@adderpositive adderpositive Awaiting requested review from adderpositive

Assignees

@adamhavel adamhavel

Labels
None yet
Projects
Issues Suite
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamhavel @adderpositive @jvaclavik