Feat/connect: Entropy check workflow in ResetDevice #15887
Draft
+332
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Buffer.from(options.trezorEntropy, 'hex'), | ||
| Buffer.from(options.hostEntropy, 'hex'), | ||
| ]); | ||
| const entropy = crypto.createHash('sha256').update(data).digest(); |
Check failure
Code scanning / CodeQL
Use of password hash with insufficient computational effort
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 16 hours ago
To fix the problem, we should replace the use of crypto.createHash('sha256') with a more secure password hashing scheme such as bcrypt. This will ensure that the hashed entropy data is resistant to brute-force attacks. The best way to fix the problem without changing existing functionality is to use the bcrypt library to hash the entropy data.
- Install the
bcryptlibrary if it is not already installed. - Import the
bcryptlibrary in the relevant file. - Replace the
crypto.createHash('sha256')function withbcrypt.hashSyncto hash the entropy data.
Suggested changeset
2
packages/connect/src/api/firmware/verifyEntropy.ts
| @@ -2,2 +2,3 @@ | ||
| import crypto from 'crypto'; | ||
| import bcrypt from 'bcrypt'; | ||
|
|
||
| @@ -92,3 +93,4 @@ | ||
| ]); | ||
| const entropy = crypto.createHash('sha256').update(data).digest(); | ||
| const saltRounds = 10; | ||
| const entropy = Buffer.from(bcrypt.hashSync(data.toString('hex'), saltRounds), 'hex'); | ||
| const strength = Math.floor(options.strength / 8); |
packages/connect/package.json
Outside changed files
| @@ -88,3 +88,4 @@ | ||
| "bs58check": "^4.0.0", | ||
| "cross-fetch": "^4.0.0" | ||
| "cross-fetch": "^4.0.0", | ||
| "bcrypt": "^5.1.1" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| bcrypt (npm) | 5.1.1 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
szymonlesisz
force-pushed
the
feat/connect-display_random
branch
from
1f5d46a to
7030c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implementation of entropy check workflow
TODO: