Chore/refactor multishare backup modal #15761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhavel
force-pushed
the
chore/refactor-multishare-backup-modal
branch
4 times, most recently
from
dbd05d5 to
f845125
Compare
adamhavel
requested review from
peter-sanderson and
jvaclavik
and removed request for
jvaclavik
adamhavel
force-pushed
the
chore/refactor-multishare-backup-modal
branch
from
f845125 to
3efc374
Compare
|
🟢 I have tested the flow and it works. |
There was a problem hiding this comment.
Good job! I leavt a fw comments and as I was playing with the code anyway, I commited my proposed changes in this branch chore/refactor-multishare-backup-modal-playground
So feel free to cherry-pick, or not ;)
There is only one commit: 4b99ab7
...nts/suite/modals/ReduxModal/UserContextModal/MultiShareBackupModal/MultiShareBackupModal.tsx
Outdated
Show resolved
Hide resolved
...suite/modals/ReduxModal/UserContextModal/MultiShareBackupModal/MultiShareBackupStepIntro.tsx
Outdated
Show resolved
Hide resolved
...ite/modals/ReduxModal/UserContextModal/MultiShareBackupModal/MultiShareBackupStepProcess.tsx
Outdated
Show resolved
Hide resolved
...ite/modals/ReduxModal/UserContextModal/MultiShareBackupModal/MultiShareBackupStepProcess.tsx
Outdated
Show resolved
Hide resolved
...ite/modals/ReduxModal/UserContextModal/MultiShareBackupModal/MultiShareBackupStepProcess.tsx
Outdated
Show resolved
Hide resolved
.../suite/modals/ReduxModal/UserContextModal/MultiShareBackupModal/MultiShareBackupStep2to4.tsx
Outdated
Show resolved
Hide resolved
peter-sanderson
approved these changes
Dec 9, 2024
|
I havent tested it after the fixups, tho. |
adamhavel
force-pushed
the
chore/refactor-multishare-backup-modal
branch
from
3e54a53 to
2f84fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots:
Before
After