chore(protobuf): update protobuf definitions (display type enum added) #15588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
mv-update-protobuf
branch
from
8138dee to
c6ea629
Compare
|
🚀 Expo preview is ready!
|
mroz22
force-pushed
the
mv-update-protobuf
branch
from
c6ea629 to
8f13b82
Compare
mroz22
changed the title
mroz22
force-pushed
the
mv-update-protobuf
branch
2 times, most recently
from
f44d36b to
0d5861f
Compare
mroz22
commented
Nov 27, 2024
packages/protobuf/src/index.ts
Outdated
| @@ -5,4 +5,4 @@ export * from './types'; | |||
| export { parseConfigure, createMessageFromName, createMessageFromType } from './utils'; | |||
| export * as MessagesSchema from './messages-schema'; | |||
| // It's problem to reexport enums when they are under MessagesSchema namespace, check packages/connect/src/types/device.ts | |||
| export { DeviceModelInternal } from './messages-schema'; | |||
| export { DeviceModelInternal, DisplayRotation, Enum_DisplayRotation } from './messages-schema'; | |||
There was a problem hiding this comment.
is this the way we want to export these? cc @martykan
There was a problem hiding this comment.
I don't know... DeviceModelInternal seems important enough to re-export separately, but I don't think it's the best approach for every single enum.
If we want to re-export in device.ts something like this should work:
export type DisplayRotation = PROTO.DisplayRotation;
packages/connect/src/types/device.ts
Outdated
| @@ -147,7 +147,7 @@ export type UnreadableDevice = BaseDevice & { | |||
| export type Device = KnownDevice | UnknownDevice | UnreadableDevice; | |||
| export type Features = PROTO.Features; | |||
|
|
|||
| export { DeviceModelInternal } from '@trezor/protobuf'; | |||
| export { DeviceModelInternal, Enum_DisplayRotation, DisplayRotation } from '@trezor/protobuf'; | |||
There was a problem hiding this comment.
the export of the underscored value seems odd, but if its intentional 🤷
peter-sanderson
approved these changes
Nov 27, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12050522421 |
|
Rebasing failed, please rebase manually. |
mroz22
commented
Nov 27, 2024
packages/suite/src/views/settings/SettingsDevice/DisplayRotation.tsx
Outdated
Show resolved
Hide resolved
mroz22
force-pushed
the
mv-update-protobuf
branch
2 times, most recently
from
9067a82 to
812bb14
Compare
mroz22
changed the title
mroz22
force-pushed
the
mv-update-protobuf
branch
from
812bb14 to
a882b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.