Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): account balance includes XRP reserve #15595

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Nov 27, 2024

XRP reserve is always included in the account balance.

Related Issue

Resolve #13900

Screenshots:

Zaznam.obrazovky.2024-11-27.v.9.46.21.mov

@PeKne PeKne requested a review from a team as a code owner November 27, 2024 08:58
Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 12
  • More info

Learn more about 𝝠 Expo Github Action

@Nodonisko
Copy link
Contributor

Woudn't this break something else? I think there was some concers that balance does or doesn't include non confirmed transactions etc. (IDK it's a mess :D)

@PeKne
Copy link
Contributor Author

PeKne commented Nov 27, 2024

@Nodonisko it should not. Desktop is using balance everywhere as well.

@PeKne
Copy link
Contributor Author

PeKne commented Nov 27, 2024

I'm missing some go back button in the cancelled firmware update state. If the user cancels the flow on device, only way to leave it is by restarting the app.

Zaznam.obrazovky.2024-11-27.v.12.59.56.mov

@Nodonisko
Copy link
Contributor

@PeKne I think you wanted to add this comment to FW upgrade PR :D Anyway this is bug, it should return automatically when flow is cancelled on device.

@Nodonisko Nodonisko merged commit 38ae448 into develop Nov 29, 2024
15 checks passed
@Nodonisko Nodonisko deleted the fix/native/ripple-reserve-included-in-balance branch November 29, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XRP balance mismatch
2 participants