Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20 n.4.1 - Display tokens on Dashboard and reflect them in assets values #7646

Closed
Nodonisko opened this issue Feb 15, 2023 · 6 comments · Fixed by #13876, #14400, #14396 or #14446
Closed

ERC20 n.4.1 - Display tokens on Dashboard and reflect them in assets values #7646

Nodonisko opened this issue Feb 15, 2023 · 6 comments · Fixed by #13876, #14400, #14396 or #14446
Assignees
@Nodonisko
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker release-native Has to be included in the upcoming release.
Milestone
Mobile - ETH tokens

Comments

@Nodonisko
Copy link
Contributor

Nodonisko commented Feb 15, 2023 •
edited by mnuky
Loading

As a user I would like to see the ERC-20 tokens reflected in total balance on dashboard in order not to be confused that some assets are included and some not.

To Do design:
Display badge "+ token(s) next to ETH
Put badge to all tokens with coin they are related to

Acceptance criteria:
ERC-20 tokens balances are reflected on dashboard Total balances
ERC-20 tokens balances are reflected in assets on dashboard
[EDIT NEW]: ERC-20 tokens balances are reflected in Wallet switcher
When user has some token and clicks on ETH on dashboard, he gets the bottom sheet with selection of assets.

Figma
@Nodonisko Nodonisko mentioned this issue Feb 15, 2023
Closed
@Nodonisko Nodonisko added the mobile Suite Lite issues and PRs label Feb 15, 2023
@mnuky mnuky added this to the Watch Only milestone Feb 16, 2023
@PeKne PeKne changed the title ERC20 n.4 - Display tokens on Dashboard and reflect them in assets values ERC20 n.4.1 - Display tokens on Dashboard and reflect them in assets values Mar 14, 2023
@PeKne PeKne changed the title ERC20 n.4.1 - Display tokens on Dashboard and reflect them in assets values ERC20 n.4 - Display tokens on Dashboard and reflect them in assets values Mar 14, 2023
@mnuky mnuky removed this from the Watch Only milestone Aug 29, 2023
@mnuky mnuky reopened this Jan 12, 2024
@sime sime self-assigned this Jan 22, 2024
@matejkriz matejkriz changed the title ERC20 n.4 - Display tokens on Dashboard and reflect them in assets values Display tokens on Dashboard and reflect them in assets values Feb 5, 2024
@matejkriz matejkriz changed the title Display tokens on Dashboard and reflect them in assets values ERC20 n.4.1 - Display tokens on Dashboard and reflect them in assets values Feb 5, 2024
@shenkys
Copy link

shenkys commented Mar 12, 2024

Research underway, back to "in progress" on 22.3.

@mnuky mnuky unassigned sime Apr 15, 2024
@mnuky mnuky mentioned this issue Apr 15, 2024
Closed
@mnuky mnuky added this to the Mobile - ETH tokens milestone May 6, 2024
@shenkys
Copy link

shenkys commented May 10, 2024

https://www.figma.com/file/xSWRW8Csq7zYJ3TiqwoIxB/Bugfixes?type=design&node-id=251-409&mode=design&t=oYqjjCX9bZBGJo5t-11

Figma

@mnuky mnuky unassigned mnuky and shenkys May 10, 2024
@mnuky mnuky mentioned this issue May 14, 2024
Closed
@Nodonisko Nodonisko mentioned this issue Aug 19, 2024
Merged
@STew790
Copy link
Contributor

STew790 commented Sep 10, 2024

Waiting for merge on this one #14234

@STew790
Copy link
Contributor

STew790 commented Sep 13, 2024

QA NOK
Unfortunately, I see different value in the dashboard graph, below the graph and in the wallet switcher.

image
image

Info

24.9.1 b2926f1

@STew790 STew790 added the QA NOK Issue doesn't pass the QA and some changes are needed. label Sep 13, 2024
@matejkriz matejkriz added the release-native Has to be included in the upcoming release. label Sep 16, 2024
This was referenced Sep 17, 2024
Merged
Merged
@Nodonisko Nodonisko mentioned this issue Sep 19, 2024
Merged
@Nodonisko
Copy link
Contributor Author

Ready to be retested

@STew790
Copy link
Contributor

STew790 commented Sep 26, 2024

QA OK
LGTM now, all balances are equal.

Info:
24.9.2 7a4ddc9

@STew790 STew790 added QA OK Issue passed QA without any blocker and removed QA NOK Issue doesn't pass the QA and some changes are needed. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nodonisko Nodonisko

Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker release-native Has to be included in the upcoming release.
Projects
Suite Mobile
Archived in project
Milestone
Mobile - ETH tokens
6 participants
@sime @matejkriz @Nodonisko @STew790 @mnuky @shenkys