Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/validate solana amount with rent #13757

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix/validate solana amount with rent #13757

merged 2 commits into from
Aug 13, 2024

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Aug 10, 2024 •
edited
Loading

Description

@tomasklim tomasklim requested a review from a team August 10, 2024 21:09
@MiroslavProchazka MiroslavProchazka force-pushed the fix/validate-solana-amount-with-rent branch from 78c651a to d51f1aa Compare August 10, 2024 21:32
@tomasklim
Copy link
Member Author

/rebase

@github-actions GitHub Actions
Copy link

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/10369045304

@trezor-ci trezor-ci force-pushed the fix/validate-solana-amount-with-rent branch from d51f1aa to 3e9fbac Compare August 13, 2024 11:42
MiroslavProchazka
MiroslavProchazka approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@MiroslavProchazka MiroslavProchazka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MiroslavProchazka MiroslavProchazka force-pushed the fix/validate-solana-amount-with-rent branch from 3e9fbac to 56ece5b Compare August 13, 2024 15:05
@tomasklim tomasklim enabled auto-merge (rebase) August 13, 2024 15:05
@tomasklim tomasklim added this to the á milestone Aug 13, 2024
@tomasklim tomasklim merged commit 9f1f76b into develop Aug 13, 2024
48 of 51 checks passed
@tomasklim tomasklim deleted the fix/validate-solana-amount-with-rent branch August 13, 2024 15:15
@bosomt
Copy link
Contributor

bosomt commented Aug 13, 2024

QA OK

@vytick @tomasklim
see https://www.notion.so/satoshilabs/Fix-validate-solana-amount-with-rent-c4a2305209b9429e8d0f24dbcce6c79a?pvs=4if there is anything i can/need to test feel free to ping me

tested on fix/validate-solana-amount-with-rent web branch

@bosomt bosomt mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiroslavProchazka MiroslavProchazka MiroslavProchazka approved these changes

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

Assignees

@bosomt bosomt

@STew790 STew790

@evgenysl evgenysl

Labels
None yet
Projects
None yet
Milestone
á
Development

Successfully merging this pull request may close these issues.
6 participants
@tomasklim @bosomt @MiroslavProchazka @STew790 @evgenysl @PeterBenc