From e024cd8bfed5b4e67fcdf82cb744207d229f9d9c Mon Sep 17 00:00:00 2001 From: Martin Varmuza Date: Mon, 2 Dec 2024 15:49:14 +0100 Subject: [PATCH] feat(suite): more meaningful troubleshooting tips for unreadeble device --- .../PrerequisitesGuide/DeviceUnreadable.tsx | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx b/packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx index 5d9cd9847a60..3e38dcfe667b 100644 --- a/packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx +++ b/packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx @@ -120,16 +120,7 @@ export const DeviceUnreadable = ({ device }: DeviceUnreadableProps) => { } // generic troubleshooting tips - const items = [ - // closing other apps and reloading should be the first step. Either we might have made a bug and let two apps to talk - // to device at the same time or there might be another application in the wild not really playing according to our rules - TROUBLESHOOTING_TIP_RECONNECT, - // if on web - try installing desktop. this takes you to using bridge which should be more powerful than WebUSB - TROUBLESHOOTING_TIP_SUITE_DESKTOP, - // unfortunately we have seen reports that even old bridge might not be enough for some Windows users. So the only chance - // is using another computer, or maybe it would be better to say another OS - TROUBLESHOOTING_TIP_DIFFERENT_COMPUTER, - ]; + const items = []; // only for unreadable HID devices if ( @@ -141,6 +132,10 @@ export const DeviceUnreadable = ({ device }: DeviceUnreadableProps) => { // If even this did not work, go to support or knowledge base // 'If the last time you updated your device firmware was in 2019 and earlier please follow instructions in the knowledge base', items.push(TROUBLESHOOTING_TIP_UNREADABLE_HID); + // if on web - try installing desktop. this takes you to using bridge which should be more powerful than WebUSB. + // at the time of writing this, there is still an option to opt-in for legacy bridge in suite-desktop which can + // communicate with this device. see the next troubleshooting point + items.push(TROUBLESHOOTING_TIP_SUITE_DESKTOP); // you might have a very old device which is no longer supported current bridge // if on desktop - try toggling between the 2 bridges we have available items.push(TROUBLESHOOTING_TIP_SUITE_DESKTOP_TOGGLE_BRIDGE); @@ -149,6 +144,14 @@ export const DeviceUnreadable = ({ device }: DeviceUnreadableProps) => { // this should be rather exceptional case that happens only when sessions synchronization is broken or other app // is not cooperating with us items.push(TROUBLESHOOTING_TIP_CLOSE_ALL_TABS); + // closing other apps and reloading should be the first step. Either we might have made a bug and let two apps to talk + // to device at the same time or there might be another application in the wild not really playing according to our rules + items.push(TROUBLESHOOTING_TIP_RECONNECT); + // if on web - try installing desktop. this takes you to using bridge which should be more powerful than WebUSB + items.push(TROUBLESHOOTING_TIP_SUITE_DESKTOP); + // unfortunately we have seen reports that even old bridge might not be enough for some Windows users. So the only chance + // is using another computer, or maybe it would be better to say another OS + items.push(TROUBLESHOOTING_TIP_DIFFERENT_COMPUTER); } return (