Skip to content

Commit c3ea1d9

Browse files
committed
fix(suite): remove useless HiddenPlaceholder code
1 parent 6a87101 commit c3ea1d9

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

packages/suite/src/components/suite/FiatValue.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@ import { HiddenPlaceholder } from 'src/components/suite';
1515

1616
import { HiddenPlaceholderProps } from './HiddenPlaceholder';
1717

18-
const StyledHiddenPlaceholder = styled((props: HiddenPlaceholderProps) => (
19-
<HiddenPlaceholder {...props} />
20-
))`
21-
font-variant-numeric: tabular-nums;
22-
`;
23-
2418
// Do NOT use any prop from <HiddenPlaceholderProps>, its here just to fix types
2519
const SameWidthNums = styled.span<HiddenPlaceholderProps>`
2620
font-variant-numeric: tabular-nums;
@@ -86,7 +80,7 @@ export const FiatValue = ({
8680
const { FiatAmountFormatter } = useFormatters();
8781
const value = shouldConvert ? fiatAmount : amount;
8882

89-
const WrapperComponent = disableHiddenPlaceholder ? SameWidthNums : StyledHiddenPlaceholder;
83+
const WrapperComponent = disableHiddenPlaceholder ? SameWidthNums : HiddenPlaceholder;
9084

9185
const isTokenKnown = useSelector(state =>
9286
selectIsSpecificCoinDefinitionKnown(state, symbol, tokenAddress || ('' as TokenAddress)),

packages/suite/src/views/suite/SwitchDevice/DeviceItem/WalletInstance.tsx

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,7 @@ import { Card, Icon, Tooltip, Row, Column, Text, Divider } from '@trezor/compone
1111
import { getAllAccounts, getTotalFiatBalance } from '@suite-common/wallet-utils';
1212
import { spacings, negativeSpacings } from '@trezor/theme';
1313

14-
import {
15-
WalletLabeling,
16-
Translation,
17-
MetadataLabeling,
18-
HiddenPlaceholder,
19-
} from 'src/components/suite';
14+
import { WalletLabeling, Translation, MetadataLabeling } from 'src/components/suite';
2015
import { useDispatch, useSelector } from 'src/hooks/suite';
2116
import { AcquiredDevice, ForegroundAppProps } from 'src/types/suite';
2217
import { selectLabelingDataForWallet } from 'src/reducers/suite/metadataReducer';
@@ -163,13 +158,11 @@ export const WalletInstance = ({
163158
</Row>
164159
</Text>
165160

166-
<HiddenPlaceholder>
167-
<FiatHeader
168-
amount={instanceBalance.toString()}
169-
size="medium"
170-
localCurrency={localCurrency}
171-
/>
172-
</HiddenPlaceholder>
161+
<FiatHeader
162+
amount={instanceBalance.toString()}
163+
size="medium"
164+
localCurrency={localCurrency}
165+
/>
173166
</Column>
174167

175168
{(isViewOnlyRendered ||

0 commit comments

Comments
 (0)