From aa7730c4e68afde035806cb897c0a07e25ef9e42 Mon Sep 17 00:00:00 2001 From: Nassim Guelbi <127761370+9albi@users.noreply.github.com> Date: Wed, 17 Jul 2024 17:07:44 +0200 Subject: [PATCH] fix: Create Communication Setting Test fixed one of the json keys 'channel_name' => 'channelName' additionally I've reordered the assertion arguments as it should be of the form : `assert.Equal(t, expected, result)` --- pkg/cloudconformity/create_communication_setting_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/cloudconformity/create_communication_setting_test.go b/pkg/cloudconformity/create_communication_setting_test.go index c85f375..02542b7 100644 --- a/pkg/cloudconformity/create_communication_setting_test.go +++ b/pkg/cloudconformity/create_communication_setting_test.go @@ -17,10 +17,10 @@ func TestCreateCommunicationSettingSuccess(t *testing.T) { response, err := client.CreateCommunicationSetting(CommunicationSettings{}) // check the results assert.Nil(t, err) - assert.Equal(t, response.Data[0].Attributes.Configuration.ChannelName, expectedChannelName) + assert.Equal(t, expectedChannelName, response.Data[0].Attributes.Configuration.ChannelName) - assert.Equal(t, response.Data[1].Attributes.Configuration.ChannelName, "testSNSChannel") - assert.Equal(t, response.Data[1].Attributes.Filter.Statuses[0], "SUCCESS") + assert.Equal(t, "testSNSChannel", response.Data[1].Attributes.Configuration.ChannelName) + assert.Equal(t, "SUCCESS", response.Data[1].Attributes.Filter.Statuses[0]) } func TestCreateCommunicationSettingFail(t *testing.T) { @@ -88,7 +88,7 @@ var testCreateCommunicationSettingSuccessResponse = ` "statuses": ["SUCCESS"] }, "configuration": { - "channel_name": "testSNSChannel", + "channelName": "testSNSChannel", "arn": "sns-t-UoU9CsK" } },