Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut for showing sets of previous training sessions during training session #59

Open
treiher opened this issue Oct 19, 2024 · 1 comment

Comments

@treiher
Copy link
Owner

treiher commented Oct 19, 2024

Concept

  • A dialog can be opened for each exercise (or set) in the training session (by clicking on an icon displayed after the exercise name).
  • The dialog shows the target values, the previous sets of the same training session (Add function to insert previous sets values #61) and the sets of previous training sessions (in a similar format as is currently used on the Exercise page).
  • If the dialog is opened for a specific set, the target values or the values of a previous set can be inserted.
  • All these values are not shown below the input fields anymore.
  • Optional: The set values of the previous training session are displayed in light grey within the input fields.
@senier
Copy link
Contributor

senier commented Oct 20, 2024

I like the concept! Especially if this new dialog is more spacious than the entries in the current training session dialog, this may actually be easier despite the additional click.

A downside that I can imagine (for my own training) is that you cannot see the goal for the next set of an exercise at a glance. As I still make progress pretty much every session, I do not have precise target loads or reps in my routines as I would need to update them all the time. Instead, I just put an indication of my target rep range and leave everything else empty (e.g. I may have a "9" in the reps field which reminds me to aim at 9-12 reps). During the session, I take this information and the information from the previous session to decide on the actual reps and load. Especially within supersets, I will usually need to have a look after every rest period to remember / decide on the values of the upcoming set.

Within the above design, I can see a couple of solutions for this:

  • Use something like a <details> element to keep the new dialog as part of the currently active set (and potentially a configuration option to decide whether it's open or collapsed by default)
  • Add tooltip (or similar) just containing the various previous values and an additional dialog to insert them
  • Preset the input fields with the previous values and have a configuration option what they are preset with (previous set, previous session, values from the routine ...)

I find your last (optional) item somewhat intriguing. It could be challenging from a usability perspective, though (light gray may be hard to distinguish from regular values). Thinking about it, it may even be worth considering to remove the input fields altogether and allow changes only in the new dialog (explicit values, previous values etc.). The input fields are a bit fiddly on a mobile anyway and I had situations where I made accidental entries while the phone was in my pocket.

Lastly, when designing the separate dialog to insert values, a way to use a modified value would be nice. I hardly ever use the exact previous value, but usually insert it and then increase the reps (because I got more reps than last session). Not sure whether that's worth the effort though. Also, I don't have a good idea the would work well on a mobile - something like spin buttons but with better usability...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants