Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Unique class names across package #63

Open
MxMartin opened this issue May 4, 2023 · 0 comments
Open

Suggestion: Unique class names across package #63

MxMartin opened this issue May 4, 2023 · 0 comments

Comments

@MxMartin
Copy link

MxMartin commented May 4, 2023

Hi!

During coding I frequently run into the problem that class names are not unique, e.g. Property and Location are defined multiple times. This leads to confusion and requires aliasing the classes whenever two classes of the same name are imported into the same module.

Could you rename them and give them more meaningful names?

E.g. the Property class in traveltimepy/dto/responses/time_filter.py could be renamed to TimeFilterResultProperties (as in fact it contains multiple different properties, not just one property).
Identically the Locationclass could become a TimeFilterLocationResult``.

Kind regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant