Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optional] include location_id column in time filter output #69

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olivierdalang
Copy link
Collaborator

Currently, the time filter algorithm only uses location_id internally (to make the request to the API) but location_id are not part of the output. For consistency with other algorithms (and also to make it more easy to know what exact location_id was used), this PR includes it in the output.

Since it's a new attribute, this should be reasonably backwards compatible (only case where it could break existing workflows is if someone already had a location_id field in the input table).

@chris-traveltime Let me know if you'd like this merged or not.

@olivierdalang olivierdalang marked this pull request as draft January 3, 2023 14:38
@olivierdalang olivierdalang mentioned this pull request Jan 3, 2023
14 tasks
@olivierdalang olivierdalang changed the title include location_id column in time filter output [optional] include location_id column in time filter output Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant