Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display validation errors #4762

Open
2 tasks done
ordago opened this issue Oct 24, 2023 · 2 comments
Open
2 tasks done

Display validation errors #4762

ordago opened this issue Oct 24, 2023 · 2 comments
Assignees
Labels

Comments

@ordago
Copy link
Contributor

ordago commented Oct 24, 2023

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

When a validation error occurs, the message is not prominent enough. The error is shown as a toast, but it disappears after some time. After that, the error can be seen by clicking on the question icon button, where it'll be shown to the user in an alert.

// eslint-disable-next-line no-alert
onClick={() => alert(props.file.error)} // TODO: move to a custom alert implementation

Some users might not be tech-savvy enough to look for the error there.

There is also the issues mentioned in the eslint rule referenced in the code.

https://eslint.org/docs/latest/rules/no-alert

I went to the docs looking for the option to enable displaying errors, but I didn't find any.

Relevant issues:
#4079

This issue mentions localizing the error messages. But the error that would be shown would be the same as the one that is already being used in the alert.

Solution

I think an option could be added to the Dashboard to enable displaying errors
chrome_dhpjjvZ0JI

I don't know preact but I think something like this would be a starting point

chrome_ML9OaxTUja

It would need to add the css for the error message and set the flag.

Alternatives

Alternatively, the error could be shown as tooltip or title.

@ordago ordago added the Feature label Oct 24, 2023
@Murderlon
Copy link
Member

Hi, this already exists. For instance, for missing meta fields:

Screenshot 2023-10-25 at 09 32 37

However it's not consistently implemented for all errors.

@arturi what do you think?

@mifi
Copy link
Contributor

mifi commented Aug 29, 2024

kind of related #5436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants