Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all used headers are explicitly included #96

Open
hugmyndakassi opened this issue Jan 30, 2024 · 1 comment
Open

Not all used headers are explicitly included #96

hugmyndakassi opened this issue Jan 30, 2024 · 1 comment

Comments

@hugmyndakassi
Copy link
Contributor

Hi,

wanted to bring another point to your attention.

I think you are technically missing an #include <stdexcept> in uthenticode.h between <optional> and <vector>. This doesn't cause an issue because evidently <optional> transiently includes <stdexcept>.

Furthermore at least for me an #include <openssl/bn.h> was missing as well in that same header. Without it I get an error for using BN_ptr = std::unique_ptr<BIGNUM, decltype(&BN_free)>;. This may be owed to the fact that I have adjusted the code in various places and bring some stuff into scope before including uthenticode and hide other stuff from it. I also don't make use of your #include <pe-parse/parse.h> ... it may play into that as well.

@woodruffw
Copy link
Member

Thanks! Yeah, any implicit header inclusions are unintentional. I'd be happy to accept a PR that makes them explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants