Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setMarkers without replacing existing markers #358

Open
abdullahtk opened this issue Feb 25, 2020 · 16 comments
Open

Use setMarkers without replacing existing markers #358

abdullahtk opened this issue Feb 25, 2020 · 16 comments
Labels
need more feedback Requires more feedback. question General question.

Comments

@abdullahtk
Copy link

Thank you for all the great work. I have a case where I want to draw different set of markers on different times on Line series. When I call series.setMarkers it replace the existing markers which I don't want that to happen. Is there a way to add markers without replacing the existing one?

@HighBreedTech

This comment has been minimized.

@timocov
Copy link
Contributor

timocov commented Feb 26, 2020

Is there a way to add markers without replacing the existing one?

Currently no. As workaround you can easily save all markers you've set before and then modify that array and set all markers again.

@timocov timocov added the need more feedback Requires more feedback. label Feb 26, 2020
@HighBreedTech

This comment has been minimized.

@abdullahtk
Copy link
Author

Is there a way to add markers without replacing the existing one?

Currently no. As workaround you can easily save all markers you've set before and then modify that array and set all markers again.

I was thinking about doing so but for my use case, I believe it won't work because:

  • I want to be able to add multiple markers on the same date/time
  • I want to be able to hide/show a set of markers without affecting other sets

@HighBreedTech

This comment has been minimized.

@abdullahtk

This comment has been minimized.

@HighBreedTech

This comment has been minimized.

@HighBreedTech

This comment has been minimized.

@timocov
Copy link
Contributor

timocov commented Feb 26, 2020

is there anyway we can get the time of the past marker set?
because using timestamp is a little bit not easy

@HighBreedTech You can easily save the date of the latest marker.

I believe it won't work because:

@abdullahtk actually it will. You need to "manage" all markers from your side, every time you want to modify markers set, you need to do that with your set and then push changed (in our case that's all markers) to the API.

please is it possible to add Marker to 11:56:01, 11:56:30, 12:17:10 all each after another because i am trying and all are going over each other.

@HighBreedTech what problem you faced with that?

I guess using setMarkers without data will clear all the markers. I haven't test that though!

Yeah, it should.

@HighBreedTech

This comment has been minimized.

@timocov

This comment has been minimized.

@timocov

This comment has been minimized.

@timocov
Copy link
Contributor

timocov commented Feb 27, 2020

I just marked some of comments here as off-topic as soon they seem aren't related to the original issue.

@HighBreedTech if you have any questions like "I spend couple of days and can't smth" or "I can't do that, can you please debug it for me?" - please ask them in our discord (see #241 (comment)) or on https://stackoverflow.com/. If you have any bug or suggestion what we need to add to the API, or what we need to modify to make it better - feel free to create an issue on github please. Let's leave this issue clean with only related the original topic comments please.

@spramuditha

This comment has been minimized.

@timocov

This comment has been minimized.

@spramuditha

This comment has been minimized.

@SlicedSilver SlicedSilver added the question General question. label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more feedback Requires more feedback. question General question.
Projects
None yet
Development

No branches or pull requests

5 participants