Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in-kind redemptions fix for realised PnL #665

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Adding in-kind redemptions fix for realised PnL #665

merged 4 commits into from
Nov 20, 2023

Conversation

miohtama
Copy link
Collaborator

@miohtama miohtama commented Nov 20, 2023 •
edited
Loading

  • Fix realised PnL calculation in the case spot positions contain in-kind redemptions
  • Allow mixing str and Path in state serialisation
  • Change hash() for TradingPairIdentifier to be independent from the internal id. Hash together (base, quote, fee) like Uniswap v3 does.

@miohtama miohtama merged commit 02167f6 into master Nov 20, 2023
5 checks passed
@AlexTheLion123
Copy link
Contributor

fixes #663

@AlexTheLion123 AlexTheLion123 linked an issue Nov 21, 2023 that may be closed by this pull request
incorrect profit on frontend 2 #663
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect profit on frontend 2
2 participants
@miohtama @AlexTheLion123